Skip to content

When polling for repo install status, ensure the correct revision is being checked#146

Merged
mvdbeek merged 1 commit intogalaxyproject:masterfrom
natefoo:shed-tools-poll-fix
Oct 5, 2019
Merged

When polling for repo install status, ensure the correct revision is being checked#146
mvdbeek merged 1 commit intogalaxyproject:masterfrom
natefoo:shed-tools-poll-fix

Conversation

@natefoo
Copy link
Copy Markdown
Member

@natefoo natefoo commented Oct 5, 2019

Otherwise any version of the repo that's already installed and encountered first in the loop will cause the poll to immediately return success.

Copy link
Copy Markdown
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mvdbeek mvdbeek merged commit de2b983 into galaxyproject:master Oct 5, 2019
@natefoo
Copy link
Copy Markdown
Member Author

natefoo commented Oct 5, 2019

Thanks @mvdbeek!

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Oct 5, 2019

Sure, thanks a lot, looking forward to latest versions on test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants