Skip to content

Add option to shed-tools test for specifying a history name#173

Merged
mvdbeek merged 2 commits intogalaxyproject:masterfrom
natefoo:shed-tools-test-history-option
May 11, 2021
Merged

Add option to shed-tools test for specifying a history name#173
mvdbeek merged 2 commits intogalaxyproject:masterfrom
natefoo:shed-tools-test-history-option

Conversation

@natefoo
Copy link
Copy Markdown
Member

@natefoo natefoo commented May 11, 2021

If at least one history with a matching name exists, the newest one will be used. If no existing history matches, one will be created with the specified name. If the option is not specified, the default (from galaxy.tool_util.verify.interactor:GalaxyInteractorApi.new_history(), currently test_history) will be used.

@natefoo natefoo force-pushed the shed-tools-test-history-option branch from 7e47ee8 to 9357ccf Compare May 11, 2021 15:20
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i'd just rename the argument to test_history_name so we can eventually add an option to target a history by id ?

Comment thread src/ephemeris/shed_tools.py Outdated
Comment thread src/ephemeris/shed_tools.py Outdated
Comment thread src/ephemeris/shed_tools.py Outdated
Comment thread src/ephemeris/shed_tools_args.py Outdated
Comment thread src/ephemeris/shed_tools_args.py Outdated
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants