Skip to content

install_resolver_dependencies keys are printed in the tool_list.yml#38

Merged
bgruening merged 8 commits intogalaxyproject:masterfrom
ARTbio:generate_tool_list_from_ga_workflows
May 5, 2017
Merged

install_resolver_dependencies keys are printed in the tool_list.yml#38
bgruening merged 8 commits intogalaxyproject:masterfrom
ARTbio:generate_tool_list_from_ga_workflows

Conversation

@drosofff
Copy link
Copy Markdown
Member

@drosofff drosofff commented May 1, 2017

with a nasty trick to preserve a more readable order of keys in the yml file (name first)
install_resolver_dependencies is always set to True

sub_dic = {'name': tool['name'], 'owner': tool['owner'], 'revision': tool['changeset_revision'],
'tool_panel_section_label': panel_label, 'tool_shed_url': 'https://'+tool['tool_shed']}
'tool_panel_section_label': panel_label, 'tool_shed_url': 'https://'+tool['tool_shed'],
'zinstall_resolver_dependencies': 'True'}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the z looks strange :)

Copy link
Copy Markdown
Member Author

@drosofff drosofff May 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is the nasty trick I mentioned... This is not a bug, this is a feature :-/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see line 63

@bgruening
Copy link
Copy Markdown
Member

@drosofff do you mind to add a test for this tool?

@drosofff
Copy link
Copy Markdown
Member Author

drosofff commented May 1, 2017

@bgruening No I don't. I put it in my todo list !

@drosofff
Copy link
Copy Markdown
Member Author

drosofff commented May 2, 2017

@bgruening here is a test. Works on my fork, should work on the upstream.

@bgruening
Copy link
Copy Markdown
Member

@drosofff thanks for the tests it looks good.
I have a general comment/hint that hopefully makes this patch easier. Have you seen this patch? #26

With this in place you only need to specify it once on top of all tools and don't need to mess with he ordering :)

drosofff referenced this pull request in ARTbio/ephemeris May 5, 2017
drosofff added 2 commits May 5, 2017 13:20
…cies, install_repository_dependencies and install_resolver_dependencies at global level as recommended by @bgruening
@bgruening
Copy link
Copy Markdown
Member

Thanks @drosofff!

@bgruening bgruening merged commit 99aee58 into galaxyproject:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants