Skip to content

safeguard revisions#70

Merged
rhpvorderman merged 1 commit intomasterfrom
bgruening-patch-1
Jan 4, 2018
Merged

safeguard revisions#70
rhpvorderman merged 1 commit intomasterfrom
bgruening-patch-1

Conversation

@bgruening
Copy link
Copy Markdown
Member

revisions can be None ....

@rhpvorderman
Copy link
Copy Markdown
Contributor

rhpvorderman commented Jan 4, 2018

revisions = repo_info.get('revisions', [])

Should never return None right? In that case it should return an empty list [] which has length zero.

Did you get an error message when running shed-tools install that indicates that something may be wrong in this assumption?

@bgruening
Copy link
Copy Markdown
Member Author

Not in this case:

>>> repo_info = {'foo': None}
>>> revisions = repo_info.get('foo', [])
>>> print revisions
None

@rhpvorderman
Copy link
Copy Markdown
Contributor

👍

@rhpvorderman rhpvorderman merged commit cb83659 into master Jan 4, 2018
@rhpvorderman rhpvorderman deleted the bgruening-patch-1 branch January 4, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants