Run data managers aggressive parallelization and refactoring.#79
Merged
rhpvorderman merged 16 commits intogalaxyproject:masterfrom Mar 20, 2018
Merged
Conversation
3106e2e to
4f6e389
Compare
Member
|
Sorry, for being so late to the game. This is great, thanks a lot @rhpvorderman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While installing a few reference genomes on my galaxy I got annoyed by the indexing steps. These take quite a long time. And
run-data-managersonly runs one data manager at a time. I feel that job scheduling should be handled by Galaxy and not byrun-data-managersso I changed the way thatrun-data-managerssubmits jobs.Now
run-data-managersfirst picks all the data managers that populate source tables (DEFAULT: ["all_fasta"]). Since other data managers depend on these tables. Then it runs them. After that it runs all the other data managers. Let galaxy figure out to schedule all these jobs.This provides a significant speedup when you're adding a vertebrate genome to the list. Instead of watching your bowtie and bwa indexes be created one after another, they are now created simultaneously.
Internally I had to completely overhaul
run-data-managers. It is a now aDataManagersobject that has a run method. This made a lot of interfunction communication much easier. Also the code is a bit cleaner now. The DataManagers object can now also be used in other scripts.Since I had to do some testing I overhauled the tests scripts as well. These are now split in 3 parts. The
shed-toolstesting was quite slow, and I did not want to wait on it all the time. There is now a separate script for testingrun-data-managerswhich made testing a bit easier.