Allow repo type change through TS API

[nsoranzo]

Changing the repository type, e.g. from "Unrestricted" to "Repository suite definition" , is allowed in the web UI in certain cases, and sometimes even suggested by a message box.

On the other hand, it is currently not possible to change the repo type through the ToolShed API, see commit 1422d87 which removed the relevant code.

I think this should be allowed, and the API request should just fail if a particular type change is not possible.

N.B.: the repository type seems to not be used on the Galaxy side, only on TS side, so I see no reason to prevent the type change if the repo has already been installed/cloned once.

Ping @martenson @jmchilton @blankenberg @mvdbeek @bgruening

[bgruening]

Seems reasonable to me, I also don't see any reason why this should not be available via the API.

[martenson]

I think it was removed from the API because in current situation (once repo is cloned you cannot do it) it adds unnecessary complexity and its usefulness is close to zero.

The important question here is whether we want to support changing the repo type at any time. If we do want that the API should support it. If we don't I would rather deprecate this functionality and remove it completely later.

[martenson]

Also please note, that the 'removed functionality' was circumventing the existing logic (no type updates of cloned repos and others) which was part of the reason it was not allowed in.

[hexylena]

Is this still interesting @nsoranzo?

[nsoranzo]

I think it is still relevant, but a corner case of having used the wrong repo type when uploading to the TS.
As discussed above, I think we could allow changing the repo type even after it was downloaded, I don't see a reason to prevent it.