Use collection hids for collection inputs in dataset names#19229
Closed
bernt-matthias wants to merge 4 commits intodevfrom
Closed
Use collection hids for collection inputs in dataset names#19229bernt-matthias wants to merge 4 commits intodevfrom
bernt-matthias wants to merge 4 commits intodevfrom
Conversation
8f03428 to
2ca2934
Compare
2ca2934 to
8000b81
Compare
output "data 1, 2, and 3" instead of "data 1, data 2, and data 3"
8000b81 to
d70fe5c
Compare
bernt-matthias
commented
Mar 14, 2025
Member
|
Can you please open this from your fork ? |
Contributor
Author
|
Ups: #19817 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For input of dataset collections to
data_collectioninputs ordatainputs withmultiple="true"the dataset name (on_string) lists the HIDs of the datasets in the input collections. This makes it more difficult than necessary to understand the history. It would be better to list the input collections.This PR does 2 things:
on_stringfrom"data 1, data 2, and data 3"to"dataset 1, 2, and 3"and analogous for collections.Discussion:
datasetwe could stick withdatacollectionwe could uselist.. to me it seems that the terms are used interchangeably .. ultimately we should decide for oneTODO:
Fixes #7467
Before (using the identifier_multiple test tool for multiple data input):
Screencast.from.02.12.2024.13.22.58.webm
After:
Screencast.from.02.12.2024.13.14.30.webm
How to test the changes?
(Select all options that apply)
License