Skip to content

Update Python dependencies#21043

Merged
mvdbeek merged 7 commits intogalaxyproject:devfrom
galaxybot:dev_auto_update_dependencies
Oct 16, 2025
Merged

Update Python dependencies#21043
mvdbeek merged 7 commits intogalaxyproject:devfrom
galaxybot:dev_auto_update_dependencies

Conversation

@galaxybot
Copy link
Copy Markdown
Contributor

by running make update-dependencies.

@github-actions github-actions Bot added this to the 26.0 milestone Oct 11, 2025
@nsoranzo nsoranzo force-pushed the dev_auto_update_dependencies branch 2 times, most recently from 9ca470d to d1f57ca Compare October 14, 2025 15:45
galaxybot and others added 4 commits October 15, 2025 15:44
by running `make update-dependencies`.
Fix the following error at Galaxy startup:

```
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.23/x64/lib/python3.9/logging/config.py", line 543, in configure
    formatters[name] = self.configure_formatter(
  File "/opt/hostedtoolcache/Python/3.9.23/x64/lib/python3.9/logging/config.py", line 655, in configure_formatter
    result = self.configure_custom(config)
  File "/opt/hostedtoolcache/Python/3.9.23/x64/lib/python3.9/logging/config.py", line 470, in configure_custom
    c = self.resolve(c)
  File "/opt/hostedtoolcache/Python/3.9.23/x64/lib/python3.9/logging/config.py", line 391, in resolve
    self.importer(used)
  File "/home/runner/work/galaxy/galaxy/galaxy root/lib/galaxy/web_stack/__init__.py", line 13, in <module>
    from galaxy.model import database_utils
  File "/home/runner/work/galaxy/galaxy/galaxy root/lib/galaxy/model/__init__.py", line 144, in <module>
    from galaxy.files.templates import (
  File "/home/runner/work/galaxy/galaxy/galaxy root/lib/galaxy/files/__init__.py", line 13, in <module>
    from galaxy.files.sources import (
  File "/home/runner/work/galaxy/galaxy/galaxy root/lib/galaxy/files/sources/__init__.py", line 19, in <module>
    from galaxy.files.models import (
  File "/home/runner/work/galaxy/galaxy/galaxy root/lib/galaxy/files/models.py", line 135, in <module>
    class FilesSourceProperties(StrictModel):
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.9/site-packages/pydantic/_internal/_model_construction.py", line 242, in __new__
    set_model_fields(cls, config_wrapper=config_wrapper, ns_resolver=ns_resolver)
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.9/site-packages/pydantic/_internal/_model_construction.py", line 566, in set_model_fields
    fields, class_vars = collect_model_fields(cls, config_wrapper, ns_resolver, typevars_map=typevars_map)
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.9/site-packages/pydantic/_internal/_fields.py", line 364, in collect_model_fields
    field_info = FieldInfo_.from_annotated_attribute(ann_type, assigned_value, _source=AnnotationSource.CLASS)
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.9/site-packages/pydantic/fields.py", line 443, in from_annotated_attribute
    field_info = FieldInfo._construct(
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.9/site-packages/pydantic/fields.py", line 519, in _construct
    merged_field_info = cls(**merged_kwargs)
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.9/site-packages/pydantic/fields.py", line 232, in __init__
Error:     raise TypeError('cannot specify both default and default_factory')
TypeError: cannot specify both default and default_factory
```
@nsoranzo nsoranzo force-pushed the dev_auto_update_dependencies branch 3 times, most recently from 27b5a7d to 62a6519 Compare October 15, 2025 16:10
Comment thread client/src/api/schema/schema.ts Outdated
[key: string]: string[];
};
tags: components["schemas"]["TagCollection"];
tags: components["schemas"]["galaxy__schema__schema__TagCollection"];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we control the model name ? this seems unfortunate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 56b74fe fixes/workarounds it.

@nsoranzo nsoranzo force-pushed the dev_auto_update_dependencies branch from 62a6519 to 47691c8 Compare October 16, 2025 00:16
It's never used as a model.
Prevents ugly component names in client schema due to model recursion in
the new `partial_model()` implementation.
@nsoranzo
Copy link
Copy Markdown
Member

Package tests failure unrelated (it's due to fastapi/fastapi#14168 , which is in fastapi 0.119.0, so not part of this PR).

@nsoranzo nsoranzo requested a review from a team October 16, 2025 08:32
@mvdbeek mvdbeek merged commit f354649 into galaxyproject:dev Oct 16, 2025
57 of 60 checks passed
@arash77
Copy link
Copy Markdown
Member

arash77 commented Oct 21, 2025

Should 7608bf6 go into the release, as it causes errors on packages using it?
for example:
https://github.com/galaxyproject/ephemeris/actions/runs/18534233909/job/52824894318?pr=229#step:5:41

@nsoranzo
Copy link
Copy Markdown
Member

Should 7608bf6 go into the release, as it causes errors on packages using it? for example: https://github.com/galaxyproject/ephemeris/actions/runs/18534233909/job/52824894318?pr=229#step:5:41

Yes. Unfortunately fastapi 0.119 contains other breaking changes in fastapi.openapi.utils.get_openapi_path() that are not easy to workaround, so package tests will continue to fail.

or something more like this:

try:
    from fastapi._compat import GenerateJsonSchema
except ImportError:
    from pydantic.json_schema import GenerateJsonSchema

This is not necessary since fastapi._compat simply re-export it from pydantic.json_schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants