Remove tabular chunked, binary and large file mako#21106
Merged
guerler merged 50 commits intogalaxyproject:devfrom Oct 29, 2025
Merged
Remove tabular chunked, binary and large file mako#21106guerler merged 50 commits intogalaxyproject:devfrom
guerler merged 50 commits intogalaxyproject:devfrom
Conversation
guerler
force-pushed
the
remove_tabular_chunked_mako
branch
from
4aecfd9 to
72862ce
Compare
guerler
changed the title
4 tasks
davelopez
reviewed
Oct 28, 2025
Contributor
davelopez
left a comment
davelopez
left a comment
There was a problem hiding this comment.
Thank you, Sam!
Some minor comments below, mostly about typing improvements.
I guess it would be great to have some Selenium tests for this TabularChunkedView if it is easy to test, or maybe there are already? I couldn't find any after a quick search.
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
guerler
force-pushed
the
remove_tabular_chunked_mako
branch
from
955afcf to
aa0cba2
Compare
Contributor
Author
|
Thank you for the review @davelopez, I added a simple selenium test, and discovered some related tests in test_allowlist_sanitization.py. |
davelopez
approved these changes
Oct 29, 2025
Contributor
davelopez
left a comment
davelopez
left a comment
There was a problem hiding this comment.
Thanks for addressing all comments!
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
tabular_chunked.mako,binary_file.makoandlarge_file.makoHow to test the changes?
(Select all options that apply)
License