Skip to content

Annotates archive explorer tests as Selenium-only#21341

Merged
jmchilton merged 1 commit intogalaxyproject:devfrom
davelopez:fix_archive_explorer_tests_playwright_not_supported
Nov 20, 2025
Merged

Annotates archive explorer tests as Selenium-only#21341
jmchilton merged 1 commit intogalaxyproject:devfrom
davelopez:fix_archive_explorer_tests_playwright_not_supported

Conversation

@davelopez
Copy link
Copy Markdown
Contributor

Pending Playwright support, not sure yet what is needed to make them compatible 🤔

This should avoid these CI failures for now:

FAILED lib/galaxy_test/selenium/test_archive_explorer.py::TestArchiveExplorer::test_search_filters_files - playwright._impl._errors.TimeoutError: ElementHandle.click: Timeout 30000ms exceeded.
Call log:
  - attempting click action
    2 × waiting for element to be visible, enabled and stable
      - element is not visible
    - retrying click action
    - waiting 20ms
    2 × waiting for element to be visible, enabled and stable
      - element is not visible
    - retrying click action
      - waiting 100ms
    56 × waiting for element to be visible, enabled and stable
       - element is not visible
     - retrying click action
       - waiting 500ms
FAILED lib/galaxy_test/selenium/test_archive_explorer.py::TestArchiveExplorer::test_select_all_functionality - playwright._impl._errors.TimeoutError: ElementHandle.click: Timeout 30000ms exceeded.
Call log:
  - attempting click action
    2 × waiting for element to be visible, enabled and stable
      - element is not visible
    - retrying click action
    - waiting 20ms
    2 × waiting for element to be visible, enabled and stable
      - element is not visible
    - retrying click action
      - waiting 100ms
    55 × waiting for element to be visible, enabled and stable
       - element is not visible
     - retrying click action
       - waiting 500ms
    - waiting for element to be visible, enabled and stable

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes area/testing labels Nov 20, 2025
@github-actions github-actions Bot added this to the 26.0 milestone Nov 20, 2025
@jmchilton jmchilton merged commit 401eda7 into galaxyproject:dev Nov 20, 2025
25 of 27 checks passed
@jmchilton
Copy link
Copy Markdown
Member

I think this is the right approach for now. I'll try to work through the compat .differences in existing tests some time but I think these decorators are totally fine for the foreseeable future - I think it is more important to get tests written than to have them working within one framework or the other.

@davelopez davelopez deleted the fix_archive_explorer_tests_playwright_not_supported branch November 21, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants