[25.1] Fix credential validation logic in tool form component#21889
Merged
davelopez merged 1 commit intogalaxyproject:release_25.1from Feb 19, 2026
Merged
Conversation
Updated the hasCredentialsErrors computed property to include a check for toolHasRequiredServiceCredentials. This ensures that the validation correctly reflects whether all required service for a required credentials are provided by the user.
davelopez
approved these changes
Feb 19, 2026
Contributor
davelopez
left a comment
davelopez
left a comment
There was a problem hiding this comment.
Thank you for the fix!
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21848
How to test the changes?
(Select all options that apply)
License