Show file size for CRAM datasets and in download tooltip#22273
Merged
mvdbeek merged 2 commits intogalaxyproject:devfrom Mar 31, 2026
Merged
Show file size for CRAM datasets and in download tooltip#22273mvdbeek merged 2 commits intogalaxyproject:devfrom
mvdbeek merged 2 commits intogalaxyproject:devfrom
Conversation
CRAM's set_peek was hardcoding "binary data" as the blurb instead of calling nice_size like every other binary datatype. This meant CRAM datasets didn't show their file size in the history panel.
Adds the dataset file size to the download button tooltip, so hovering shows something like "Download (1.5 GB)" instead of just "Download". Uses the existing bytesToString formatter. Falls back to plain "Download" for empty or zero-size datasets.
bgruening
approved these changes
Mar 27, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRAM's
set_peekwas hardcoding its blurb as "binary data" instead of callingnice_size()like every other binary datatype, so CRAM datasets didn't show their file size in the history panel. This came up when someone uploaded a CRAM that was unexpectedly small and there was no visible indication.Also adds the dataset file size to the download button tooltip -- hovering now shows "Download (1.5 GB)" instead of just "Download". This surfaces size information without adding clutter to the history UI. Follows the same pattern already used in
DownloadWorkbookButton.vue.