Skip to content

Lint and package fixes#22469

Merged
mvdbeek merged 3 commits intogalaxyproject:devfrom
nsoranzo:lint_and_package_fixes
Apr 13, 2026
Merged

Lint and package fixes#22469
mvdbeek merged 3 commits intogalaxyproject:devfrom
nsoranzo:lint_and_package_fixes

Conversation

@nsoranzo
Copy link
Copy Markdown
Member

Includes slightly-modified mypy and packaging fixes from #22464 , plus:

  • Pin rocrate<0.15.0 until roc-validator supports RO-Crate Metadata Specification 1.2

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

…cification 1.2

rocrate 0.15.0 produces crates conforming to 1.2 spec by default, which
causes roc-validator validation errors like:

```
The RO-Crate metadata file descriptor MUST have a `conformsTo` property with the RO-Crate specification version
```

xref crs4/rocrate-validator#107

Also:
- Remove unused `BaseWorkflowPopulator.validate_invocation_crate_directory()` method.
@github-actions github-actions Bot added this to the 26.1 milestone Apr 13, 2026
@mvdbeek mvdbeek merged commit 6a80aa7 into galaxyproject:dev Apr 13, 2026
60 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Apr 13, 2026
@nsoranzo nsoranzo deleted the lint_and_package_fixes branch April 13, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants