Skip to content

Add legacy job submission fallback#22555

Open
guerler wants to merge 6 commits intogalaxyproject:devfrom
guerler:toolrequests.001
Open

Add legacy job submission fallback#22555
guerler wants to merge 6 commits intogalaxyproject:devfrom
guerler:toolrequests.001

Conversation

@guerler
Copy link
Copy Markdown
Contributor

@guerler guerler commented Apr 24, 2026

This PR completes the /api/tools/api/jobs migration by adding a minimal fallback.

The client routes through submitAsync only when three conditions hold:

  1. enable_tool_requests is enabled (default true, exposed via lib/galaxy/managers/configuration.py),
  2. Celery is available, and
  3. the tool exposes a typed parameter schema.

If any of these conditions are not met, submission falls back to the legacy /api/tools path via submitLegacy.

A Sentry info message is emitted only in the relevant case where tool requests and Celery are enabled but typed parameters are missing, allowing us to identify tools that still need schema support.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 26.1 milestone Apr 24, 2026
@guerler guerler added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Apr 24, 2026
@guerler guerler force-pushed the toolrequests.001 branch 2 times, most recently from f595c4c to caef656 Compare April 27, 2026 09:55
@guerler guerler marked this pull request as ready for review April 27, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant