[26.0] Fix error handling for Help Forum integration#22604
Open
davelopez wants to merge 2 commits intogalaxyproject:release_26.0from
Open
[26.0] Fix error handling for Help Forum integration#22604davelopez wants to merge 2 commits intogalaxyproject:release_26.0from
davelopez wants to merge 2 commits intogalaxyproject:release_26.0from
Conversation
mvdbeek
approved these changes
Apr 30, 2026
Member
|
Could the connection error handling could potentially be masking real issues that require some kind of server action (like updating the url, certificate checks etc)? I've been ignoring a low error rate in Sentry so far. |
Enhances error reporting and logging for Help Forum API failures, distinguishing between connection errors, timeouts, client errors, and server errors. Provides more actionable error messages for misconfiguration cases and improves diagnostics for administrators.
Contributor
Author
|
Good point! The last commit suggested by Copilot should ensure that actionable errors are reported to Sentry with better exception details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22599
The Help forum returned
Service Unavailable(503), but there was no error handling in the/api/help/forum/searchendpoint. TheJSONDecodeError: Expecting value: line 1 column 1 (char 0)error in #22599 was somewhat misleading becauseresponse.json()was trying to parse the 503 HTML error as JSON.This properly handles most errors and surfaces the connectivity ones to the user to clarify expectations. Potential parsing errors are still considered internal, but should be reported more clearly in Sentry.
How to test the changes?
License