Skip to content

Fix long title squashing in g-card#22621

Merged
davelopez merged 2 commits intogalaxyproject:devfrom
mvdbeek:fix-export-card
May 4, 2026
Merged

Fix long title squashing in g-card#22621
davelopez merged 2 commits intogalaxyproject:devfrom
mvdbeek:fix-export-card

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented May 2, 2026

Before:
Screenshot 2026-05-02 at 11 32 27
After:
Screenshot 2026-05-02 at 11 32 12

first commit cherry-picked from dannon/invocation-tag-wrap which hasn't been merged yet.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

dannon and others added 2 commits May 2, 2026 11:25
Add responsive layout to GCard header that prevents badges from
squashing the title. Title section now has min-width of 50% and
badges wrap to next line when needed.
GCard's responsive width rules use `@container cards-list (max-width: ...)`
to drop cards from 1/3 width to 1/2 / full width on narrow viewports.
RecentDownloads.vue had no `container: cards-list / inline-size`
declaration anywhere up the tree, so those queries never fired and
cards stayed at `calc(100% / 3)` regardless of viewport width — which,
combined with the recently fixed title squashing, was producing
per-syllable title wrapping in the export card on narrow screens.

Match the idiom used by WorkflowCardList and HistoryCardList.
@github-project-automation github-project-automation Bot moved this to Needs Review in Galaxy Dev - weeklies May 2, 2026
@github-actions github-actions Bot added this to the 26.1 milestone May 2, 2026
@github-actions github-actions Bot changed the title [26.0] Fix long title squashing in g-card Fix long title squashing in g-card May 2, 2026
Copy link
Copy Markdown
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davelopez davelopez merged commit bf43c74 into galaxyproject:dev May 4, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies May 4, 2026
@davelopez
Copy link
Copy Markdown
Contributor

Got overexcited and merged! Should we backport it to 26.0 as a bug fix?

@itisAliRH
Copy link
Copy Markdown
Member

Badges are going under the title, and it feels weird/inconsistent with other cards in the list, as you see in the screenshots below.

image image

Should we revert these changes and fix them in a better way? I also think the GCard styling might need an overhaul/review in its responsive system.

I was about to add this comment, but it got merged sooner.

@davelopez
Copy link
Copy Markdown
Contributor

Should we revert these changes and fix them in a better way? I also think the GCard styling might need an overhaul/review in its responsive system.
I was about to add this comment, but it got merged sooner.

I think it would be best to backport these commits to 26.0, then add the "proper fix" on top directly on 26.0, so it will be cleaner when merged forward.

Sorry for the premature merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants