Honor group-derived roles in unprivileged tool access check#22623
Open
mvdbeek wants to merge 1 commit intogalaxyproject:devfrom
Open
Honor group-derived roles in unprivileged tool access check#22623mvdbeek wants to merge 1 commit intogalaxyproject:devfrom
mvdbeek wants to merge 1 commit intogalaxyproject:devfrom
Conversation
DynamicToolManager.ensure_can_use_unprivileged_tool only joined UserRoleAssociation directly, so users granted USER_TOOL_EXECUTE via group membership were denied access. Delegate to User.all_roles(), the project-wide single source of truth for "every role this user has, direct or via groups", instead of maintaining a parallel SQL query that already drifted. Also adds an api regression test exercising the group-inherited path.
mvdbeek
force-pushed
the
fix-user-tool-access-groups
branch
from
00c3b9c to
5080ecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicToolManager.ensure_can_use_unprivileged_tool only joined UserRoleAssociation directly, so users granted USER_TOOL_EXECUTE via group membership were denied access. Delegate to User.all_roles(), the project-wide single source of truth for "every role this user has, direct or via groups", instead of maintaining a parallel SQL query that already drifted.
Also adds an api regression test exercising the group-inherited path.
How to test the changes?
(Select all options that apply)
License