Improve type annotation of workflow management methods#22637
Open
nsoranzo wants to merge 4 commits intogalaxyproject:devfrom
Open
Improve type annotation of workflow management methods#22637nsoranzo wants to merge 4 commits intogalaxyproject:devfrom
nsoranzo wants to merge 4 commits intogalaxyproject:devfrom
Conversation
github-actions
Bot
added
area/API
area/workflows
area/database
mvdbeek
approved these changes
May 5, 2026
| if step.upgrade_messages: | ||
| has_upgrade_messages = True | ||
| if step.type in ("tool", "subworkflow", None): | ||
| assert isinstance(step.module, (ToolModule, SubWorkflowModule)) |
Member
There was a problem hiding this comment.
This seems surprising in combination with None in the if gaurd ?
Member
Author
There was a problem hiding this comment.
The None comes from #10121 . My understanding is that if step.type is None, we assume that it's a tool.
| if step_errors: | ||
| errors[step.id] = step_errors | ||
| if missing_tools: | ||
| workflow.annotation = self.get_item_annotation_str(trans.sa_session, trans.user, workflow) |
Member
There was a problem hiding this comment.
Is that because we never serialize the annotation ?
Member
Author
There was a problem hiding this comment.
The Workflow class/table doesn't have an annotation field (which is flagged by mypy). This comes from #2935 and seems unused.
nsoranzo
force-pushed
the
improve_wf_management_type_annot
branch
from
5e3a417 to
85ae996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
How to test the changes?
(Select all options that apply)
License