Undo dataset renaming for URL uploads#3996
Merged
natefoo merged 1 commit intogalaxyproject:devfrom May 2, 2017
Merged
Conversation
Member
|
Yeah, I concur, we'll shoot for a better solution in 17.09. |
jmchilton
added a commit
to jmchilton/ephemeris
that referenced
this pull request
May 8, 2018
We essentially don't want to change the Galaxy API to loose the URL (galaxyproject/galaxy#3695, galaxyproject/galaxy#3996), we tried at some point and had to revert it. The new upload API is smart though and can be used to set a name at upload time and embed the URL we may want to have around later in the info of the dataset. I'd prefer to make this explicit in format if that is okay, so it remains a proper superset of the real API format - I've added an example of doing that here. Unfortunately for the legacy API, this will not work because we aren't exposing the name option in bioblend's library upload options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, here is the suggestion to undo this for the release and revisit it later with ideas provided in #3695. ping @natefoo