Selenium Testing of Jupyter Notebooks#4694
Closed
jmchilton wants to merge 14 commits intogalaxyproject:devfrom
Closed
Selenium Testing of Jupyter Notebooks#4694jmchilton wants to merge 14 commits intogalaxyproject:devfrom
jmchilton wants to merge 14 commits intogalaxyproject:devfrom
Conversation
20f3644 to
8e355f3
Compare
Member
Author
|
Pulled this out of WIP and added a couple more bug fixes from Selenium runs over the past 12 hours. I may pull the fixes out into their own PR. |
5538d85 to
2b48fc4
Compare
2b48fc4 to
9433945
Compare
Implement different "WAIT_TYPES" and try to sleep for different amounts of time based on what is being waited for. Replace sleep statements in addition to Selenium wait on statements.
Creates and deletes a history for tests - good for tests meant to aim at production servers that need to have useful metadata and need to be cleaned up.
9433945 to
b560130
Compare
Merged
Member
|
Included in #4732, which was merged. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on bug fixes from #4687.
This adds a test case for testing Jupyter notebook execution. This test will "skip" on Jenkins because it isn't configured, but with the enhancements in this branch can be targeted against usegalaxy.org using the command:
To make this possible cleanly, I've implemented a bunch of generic infrastructure bits for Selenium testing in other commits. These include:
@managed_historydecorator for Selenium tests that starts the test by creating a history with a name corresponding to the time and name of that test and deletes the history at the end of the test. This won't stop a proliferation of useless histories on main corresponding to the test but it will at least make sure these tests are cleaned up and organized by name.ensure_registered=True. Previously that class attribute would force a new registration for each test case - not it just forces a login one way or the other. Either a new registration or a using the supplies credentials as demonstrated above.5might be appropriate for usegalaxy.org).