Skip to content

[17.09] GIEs: Grandfather automatic uppercasing of some env_override variables#4760

Merged
martenson merged 1 commit intogalaxyproject:release_17.09from
natefoo:gie-upper-grandfather
Oct 5, 2017
Merged

[17.09] GIEs: Grandfather automatic uppercasing of some env_override variables#4760
martenson merged 1 commit intogalaxyproject:release_17.09from
natefoo:gie-upper-grandfather

Conversation

@natefoo
Copy link
Copy Markdown
Member

@natefoo natefoo commented Oct 5, 2017

Automatic loading of the launched-from dataset was broken by #4458, this restores that functionality without reverting the change made in #4458 by setting a list of "grandfathered" variables whose names will be automatically uppercased.

ping @erasche

@hexylena
Copy link
Copy Markdown
Member

hexylena commented Oct 5, 2017

bandaids all the way down. Looks good to me. 👍

@martenson
Copy link
Copy Markdown
Member

TIL frozenset

@martenson martenson merged commit f9eae90 into galaxyproject:release_17.09 Oct 5, 2017
@natefoo
Copy link
Copy Markdown
Member Author

natefoo commented Oct 5, 2017

Thanks @erasche and @martenson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants