Interactive tools cleanup#8574
Merged
jmchilton merged 18 commits intogalaxyproject:devfrom Sep 6, 2019
Merged
Conversation
Contributor
|
This PR was merged without a 'kind/' tag, please correct. |
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Dec 19, 2019
In galaxyproject#7494 and galaxyproject#8574 , the abstract `parse_interactivetool()` method was added to the `ToolSource` class without a corresponding implementation in its `CwlToolSource` subclass, leading to the following error: ``` In [4]: from galaxy.tool_util.parser.cwl import CwlToolSource In [5]: cts = CwlToolSource('path') --------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-6-2f94370fb293> in <module>() ----> 1 cts = CwlToolSource('path') TypeError: Can't instantiate abstract class CwlToolSource with abstract methods parse_interactivetool ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is unifying the naming to use interactive tools across the code base and should make it easier for contributors.