More linting configurablity.#140
Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom Apr 24, 2015
Merged
Conversation
Add --skip argument to lint and shed_lint to pass in modules to skip while linting - I think the common ones are going to be citations and xml_order - so that would be --skip 'citations,xml_order' for instance. (TODO: Probably worth still catching unknown top-level tags even if xml_order is disabled - so those should be split out I guess). A default value for skip can be specified by specifing a list of items in ``~/.planemo.yml`` under a ``lint_skip`` key. Also improves the display of linting so the short name is what is display - e.g. user will now see "Applying linter citations" and not "Appling linter lint_citations".
jmchilton
added a commit
that referenced
this pull request
Apr 24, 2015
More linting configurablity.
Member
you know, in all of those awesome changes, not one of them is rST and in the docs/ folder :P, <3 |
Member
Author
|
Yes, I will tidy things up when I work on |
Member
|
Okay, just giving ya a hard time. Have a good weekend fre. 24. apr. 2015 kl. 15.06 skrev John Chilton notifications@github.com:
|
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--skipargument tolintandshed_lintto pass in modules to skip while linting - I think the common ones are going to becitationsandxml_order- so that would be--skip 'citations,xml_order'for instance. (TODO: Probably worth still catching unknown top-level tags even if xml_order is disabled - so those should be split out I guess).A default value for skip can be specified on a per-user basis by specifying a list of items in
~/.planemo.ymlunder alint_skipkey.This commit also improves the display of linting so the short name is what is display - e.g. user will now see "Applying linter citations" and not "Appling linter lint_citations".