Pass the tool file name when linting so that errors can reference it#852
Closed
natefoo wants to merge 1 commit intogalaxyproject:masterfrom
Closed
Pass the tool file name when linting so that errors can reference it#852natefoo wants to merge 1 commit intogalaxyproject:masterfrom
natefoo wants to merge 1 commit intogalaxyproject:masterfrom
Conversation
Contributor
|
The change looks good, but the tests fail, e.g. |
Member
Author
|
@peterjc thanks for checking this out, galaxyproject/galaxy-lib#121 needs to be merged and a new release of galaxy-lib made before these can pass. |
Member
|
depending PR is merged, waiting for new galaxy-lib release. |
Member
|
I don't have access to this repo but I opened a new PR with fixes and an updated merge @ #871. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Requires the changes in galaxyproject/galaxy-lib#121 so tests will fail until there's a new galaxy-lib release with those changes.