Skip to content

Pass the tool file name when linting so that errors can reference it#852

Closed
natefoo wants to merge 1 commit intogalaxyproject:masterfrom
natefoo:xml-lint-name
Closed

Pass the tool file name when linting so that errors can reference it#852
natefoo wants to merge 1 commit intogalaxyproject:masterfrom
natefoo:xml-lint-name

Conversation

@natefoo
Copy link
Copy Markdown
Member

@natefoo natefoo commented Jun 26, 2018

Before:

Applying linter tool_xsd... FAIL
.. ERROR: Invalid tmpfNqQF8 found. Errors [/var/folders/ct/z_jrb3314w73ktpxwg_bwx_c0000gn/T/tmpfNqQF8:4:0:ERROR:SCHEMASV:SCHEMAV_CVC_COMPLEX_TYPE_4: Element 'requirement': The attribute 'type' is required but missing.]

After:

Applying linter tool_xsd... FAIL
.. ERROR: Invalid XML found in file: pear.xml. Errors [/var/folders/ct/z_jrb3314w73ktpxwg_bwx_c0000gn/T/tmpMBoCs8:4:0:ERROR:SCHEMASV:SCHEMAV_CVC_COMPLEX_TYPE_4: Element 'requirement': The attribute 'type' is required but missing.]

Requires the changes in galaxyproject/galaxy-lib#121 so tests will fail until there's a new galaxy-lib release with those changes.

@peterjc
Copy link
Copy Markdown
Contributor

peterjc commented Jun 29, 2018

The change looks good, but the tests fail, e.g.

No matching distribution found for galaxy-lib>=18.5.14 (from -r requirements.txt (line 16))

@natefoo
Copy link
Copy Markdown
Member Author

natefoo commented Jul 9, 2018

@peterjc thanks for checking this out, galaxyproject/galaxy-lib#121 needs to be merged and a new release of galaxy-lib made before these can pass.

@bgruening
Copy link
Copy Markdown
Member

depending PR is merged, waiting for new galaxy-lib release.
Thanks @natefoo!

@jmchilton
Copy link
Copy Markdown
Member

I don't have access to this repo but I opened a new PR with fixes and an updated merge @ #871.

@jmchilton jmchilton closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants