fix: guard setupFsWrapper loop against missing fs keys on Node 24#39573
Open
McLeodSean wants to merge 2 commits into
Open
fix: guard setupFsWrapper loop against missing fs keys on Node 24#39573McLeodSean wants to merge 2 commits into
McLeodSean wants to merge 2 commits into
Conversation
gatsbot
Bot
added
the
status: triage needed
serhalp
added
status: accepted
and removed
status: triage needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guards the
setupFsWrapperloop inpackages/gatsby/src/utils/page-ssr-module/lambda.tsagainst
fs[key]being undefined.On Node 24,
fs.F_OK,fs.R_OK,fs.W_OK, andfs.X_OKare non-enumerable getters(DEP0176). They drop out of
fs-extra's spread re-exports, sofs-extra.F_OK === undefinedon Node 24.
linkfsthen writes those names onto the linked object asundefined. Theexisting loop calls
Object.hasOwnProperty.call(fs[key], 'native')without a null checkand crashes on Node 24 in any read-only filesystem deploy (Netlify Functions, etc.).
Documentation
N/A
Tests
No tests exist for
lambda.ts(seems gnarly), but this change is a safer option than the existing solution.Related Issues