Describe the bug
Very minor bug, but it would be great if this could be fixed:
The Gzip encoder has an optional Comment field that allows users to supply comment. (Documented in rfc1952, see FCOMMENT). It is implemented in Gzip.mjs but there's a typo - "options.flags.fcommenct" should actually be "options.flags.fcomment", as I assume from the context.
To Reproduce
- Open CyberChef
- Select
Gzip operation and deflate some text, save the output (better as hex).
- Put something in the
Comment field, compare the new output with the one in previous step.
- Observe that the comment was not put into the deflated data. (Although the new output will be different because different timestamps are used).
Expected behaviour
The text in the Comment field should present in the deflated data.
Desktop (if relevant, please complete the following information):
- CyberChef version: [9.9.0]
Describe the bug
Very minor bug, but it would be great if this could be fixed:
The Gzip encoder has an optional
Commentfield that allows users to supply comment. (Documented in rfc1952, seeFCOMMENT). It is implemented in Gzip.mjs but there's a typo - "options.flags.fcommenct" should actually be "options.flags.fcomment", as I assume from the context.To Reproduce
Gzipoperation and deflate some text, save the output (better as hex).Commentfield, compare the new output with the one in previous step.Expected behaviour
The text in the
Commentfield should present in the deflated data.Desktop (if relevant, please complete the following information):