Add Parse Ethernet frame Operation, allow Parse IPv4 Header to cascade#1722
Merged
GCHQDeveloper581 merged 14 commits intogchq:masterfrom Mar 21, 2026
Merged
Add Parse Ethernet frame Operation, allow Parse IPv4 Header to cascade#1722GCHQDeveloper581 merged 14 commits intogchq:masterfrom
GCHQDeveloper581 merged 14 commits intogchq:masterfrom
Conversation
a3957273
previously requested changes
Feb 22, 2024
Kalkran
changed the title
Contributor
Author
|
An accidental push before switching branches broke UI tests. These are now fixed. |
Contributor
Author
|
@a3957273 Could you take another look at this before it disappears into page 2? |
GCHQDeveloper581
dismissed
a3957273’s stale review
Review comments have been addressed and original reviewer is no longer active on the project.
GCHQDeveloper581
approved these changes
Mar 21, 2026
Contributor
GCHQDeveloper581
left a comment
GCHQDeveloper581
left a comment
There was a problem hiding this comment.
Looks good! Thanks for your contribution, and sorry it has taken so long to process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new operation+tests that parses Ethernet frames.
Recently, I've been provided with Base64-encoded single packets which are annoying to decode manually, or even to strip the Ethernet header off.
This operation adds a basic information output and a 'packet data'-only which allows cascading to other Networking-related parsers (ie IPv4). I am still playing with the idea of updating those to allow the return of encapsulated data as well - allowing a quick/basic packet analysis through a recipe.