Added the ability to paste one or more Images from the Clipboard #1876
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -151,6 +151,18 @@ class InputWaiter { | |
| // Event handlers | ||
| EditorView.domEventHandlers({ | ||
| paste(event, view) { | ||
| const clipboardData = event.clipboardData || window.clipboardData; | ||
| const items = clipboardData.items; | ||
| event.target.files = []; | ||
|
Member
There was a problem hiding this comment. It seems like bad practice to me to add a custom attribute to an external type. Couldn't we create this list as a local variable, and update the signature of |
||
| for (let i = 0; i < items.length; i++) { | ||
| const item = items[i]; | ||
| if (item.type.indexOf("image") !== -1) { | ||
|
Member
There was a problem hiding this comment. It would be good if we could support all file types, rather than just images. Could you not instead check |
||
| const file = item.getAsFile(); | ||
| event.target.files.push(file); | ||
|
|
||
| event.preventDefault(); // Prevent the default paste behavior | ||
| } | ||
| } | ||
| setTimeout(() => { | ||
| self.afterPaste(event); | ||
| }); | ||
|
|
@@ -917,6 +929,9 @@ class InputWaiter { | |
| * @param {event} e | ||
| */ | ||
| afterPaste(e) { | ||
| if (e.target.files.length > 0) { | ||
| this.loadUIFiles(e.target.files); | ||
| } | ||
| // If EOL has been fixed, skip this. | ||
| if (this.eolState > 1) return; | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t-martine what is the purpose of
window.clipboardDatahere? I cannot find any documentation for that property.ClipboardEvent.clipboardDatais baseline widely available, so I would have thought it is fine to just use that: https://developer.mozilla.org/en-US/docs/Web/API/ClipboardEvent/clipboardData#browser_compatibilityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was meant for backwards compatibility with IE11 but I agree to remove it since IE is officially out of support for a while now.
https://stackoverflow.com/questions/56063191/javascript-code-for-copy-to-clipboard-wont-work-in-internet-explorer-11