Fix npm publish - Run "npm ci" and "npm run node" under node 18 then switch to node 24.5#2192
Merged
GCHQDeveloper581 merged 1 commit intogchq:masterfrom Feb 12, 2026
Conversation
GCHQDeveloper581
changed the title
C85297
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package on npm.js doesn't contain the machine-generated files because they weren't built as part of the publish.
Currently there's a problem because we cant run "npm run node" on Node >20 due to incompatibilities
But npm publish has to be run under Node >=24.5 in order to use trusted publishing
This PR works around this by initially working with Node 18 and then switching to Node 24.5 just before the publish is done.
Use of multiple actions/setup-node instances within a single job has been tested to work elsewhere with a separate action on a throwaway branch.