Skip to content

fix: fromDecimal Auto delimiter now correctly parses multiple numbers #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
min23asdw wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix: fromDecimal Auto delimiter now correctly parses multiple numbers #2270

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae0e989
fix: handle Auto delimiter correctly in fromDecimal
min23asdw Mar 21, 2026
d09ba82
test: add Auto delimiter tests for newline and signed values
min23asdw Mar 21, 2026
7bbe0e5
Merge branch 'master' into fix/from-decimal-auto-delim
min23asdw Mar 22, 2026
7d52241
use ternary + regexRep pattern matching Hex.mjs
min23asdw Mar 23, 2026
4b0659d
Merge branch 'fix/from-decimal-auto-delim' of https://github.com/min2…
min23asdw Mar 23, 2026
7d97123
feat: add Auto delimiter option to From Decimal operation
min23asdw Mar 23, 2026
f768c46
Merge branch 'master' into fix/from-decimal-auto-delim
min23asdw Mar 24, 2026
8e581d5
Merge branch 'master' into fix/from-decimal-auto-delim
min23asdw Mar 30, 2026
517ad85
Merge branch 'master' into fix/from-decimal-auto-delim
min23asdw Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/core/lib/Decimal.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,17 @@ import Utils from "../Utils.mjs";
* fromDecimal("10:20:30", "Colon");
*/
export function fromDecimal(data, delim="Auto") {
delim = Utils.charRep(delim);
const output = [];
let byteStr = data.split(delim);
if (byteStr[byteStr.length-1] === "")
byteStr = byteStr.slice(0, byteStr.length-1);
let byteStr;
if (delim === "Auto") {
byteStr = data.split(/[^\d-]+/);
} else {
delim = Utils.charRep(delim);
byteStr = data.split(delim);
}
Comment thread
min23asdw marked this conversation as resolved.
Outdated

byteStr = byteStr.filter(str => str !== "");

const output = [];
for (let i = 0; i < byteStr.length; i++) {
output[i] = parseInt(byteStr[i], 10);
}
Expand Down
55 changes: 55 additions & 0 deletions tests/operations/tests/FromDecimal.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,59 @@ TestRegister.addTests([
},
],
},
{
name: "From Decimal with Auto delimiter (space)",
input: "72 101 108 108 111",
expectedOutput: "Hello",
recipeConfig: [
{
op: "From Decimal",
args: ["Auto", false]
},
],
},
{
name: "From Decimal with Auto delimiter (comma)",
input: "72,101,108,108,111",
expectedOutput: "Hello",
recipeConfig: [
{
op: "From Decimal",
args: ["Auto", false]
},
],
},
{
name: "From Decimal with Auto delimiter (mixed)",
input: "72, 101 : 108; 108\t111",
expectedOutput: "Hello",
recipeConfig: [
{
op: "From Decimal",
args: ["Auto", false]
},
],
},
{
name: "From Decimal with Auto delimiter (newline)",
input: "72\n101\n108\n108\n111",
expectedOutput: "Hello",
recipeConfig: [
{
op: "From Decimal",
args: ["Auto", false]
},
],
},
{
name: "From Decimal with Auto delimiter and signed values",
input: "-130 -140 -152 -151 115 33 0 -1",
expectedOutput: "~this!\u0000\u00ff",
recipeConfig: [
{
op: "From Decimal",
args: ["Auto", true]
},
],
},
]);
Loading
⚡