Support hexadecimal in numeric sort#385
Merged
n1474335 merged 3 commits intogchq:masterfrom Nov 7, 2018
Merged
Conversation
qistoph
changed the title
Member
|
Please could you add some unit tests to cover your new use cases? |
d98762625
suggested changes
Oct 12, 2018
- Use Array.map instead of for-loop - Add test case
Member
|
Nice addition! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for hexadecimal values to the sorting module.
Example input:
Expected output: