AES encrypt/decrypt padding option#867
Closed
Storms-Engineering wants to merge 3 commits intogchq:masterfrom
Storms-Engineering:AES-encrypt-padding-option
Closed
AES encrypt/decrypt padding option#867Storms-Engineering wants to merge 3 commits intogchq:masterfrom Storms-Engineering:AES-encrypt-padding-option
Storms-Engineering wants to merge 3 commits intogchq:masterfrom
Storms-Engineering:AES-encrypt-padding-option
Conversation
added 3 commits
October 12, 2019 08:44
Encryption operation now checks the length of the IV. Also changed test to use utf8 instead of HEX because the hex string wasn't valid.
Added new padding option to AESencryption/decryption that asks if they want padding or not.
This reverts commit b785f44.
Member
|
Hi @Storms-Engineering, thanks for raising this. I'm going to close it for now as it's a fair way off completion. If you get it into a more complete state, feel free to resubmit. |
This was referenced May 21, 2020
This was referenced Sep 26, 2022
This was referenced Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial pull request. This pull breaks some of the tests, which I haven't had time to work through yet. This does add support whether or not you want padding added to the encryption/decryption. It doesn't have any nice error messages, or any checks on padding. But I wanted to at least add this to the pull, so it can be reviewed, since I don't have time to do the rest at the moment. This is for issue #567.