Conversation
|
@gciruelos can you merge this? |
|
thank you for pinging me, whenever I don't respond please do Please remove accents from the note names, let's keep everything in English. |
Since I'm sub classing the Letter class, when renaming the variables, everything must be re-implemented. Or am I missing something? |
|
Yes, I think in this case refactoring the Letter class might be the easiest. |
| """ | ||
| Another tone naming. | ||
|
|
||
| There are still 7: Dó, Ré, Mi, Fá, Sol, Lá, and Si. |
There was a problem hiding this comment.
since these names are language-dependent, consider using locale, reading LC_* env, or accepting a lang option to get those name in the desired locale?
|
Please resolve conflicts |
No description provided.