Skip to content

add two initial feature flags, api-session-auth and api-bearer-auth #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donsizemore wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

add two initial feature flags, api-session-auth and api-bearer-auth #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4df859
#279 add two initial feature flags, api-session-auth and api-bearer-auth
May 19, 2023
ab95d1e
Merge remote-tracking branch 'origin/develop' into 279_feature_flags
May 25, 2023
274051b
#279 add new bearer-auth and session-auth group_vars
May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ dataverse:
allow_signups: true
api:
allow_lookup: false
bearer_auth: false
blocked_endpoints: "admin,builtin-users,test"
blocked_policy: "localhost-only"
location: "http://localhost:8080/api"
session_auth: false
test_suite: false
# possible test values from https://github.com/IQSS/dataverse/blob/develop/conf/docker-aio/run-test-suite.sh#L11
# beware DataversesIT and DatasetsIT at minimum must be run for any other tests to succeed. have fun.
Expand Down
11 changes: 11 additions & 0 deletions tasks/dataverse-optional-settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,14 @@
shell: '{{ payara_dir}}/bin/asadmin create-jvm-options "-Ddataverse.oai.server.maxrecords={{ harvest.oaiserver.maxrecords }}"'
when: harvest.oaiserver.maxrecords is defined

- name: set DATAVERSE_FEATURE_API_SESSION_AUTH=1 when told
become: yes
become_user: "{{ dataverse.payara.user }}"
shell: '{{ payara_dir}}/bin/asadmin create-jvm-options "-Ddataverse.feature.api-session-auth=true"'
when: dataverse.api.session_auth == true

- name: set DATAVERSE_FEATURE_API_BEARER_AUTH=1 when told
become: yes
become_user: "{{ dataverse.payara.user }}"
shell: '{{ payara_dir}}/bin/asadmin create-jvm-options "-Ddataverse.feature.api-bearer-auth=true"'
when: dataverse.api.bearer_auth == true
2 changes: 2 additions & 0 deletions tests/group_vars/jenkins.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ dataverse:
allow_signups: true
api:
allow_lookup: false
bearer_auth: true
blocked_endpoints: "admin,test"
blocked_policy: "localhost-only"
location: "http://localhost:8080/api"
session_auth: true
test_suite: true
# possible test values from https://github.com/IQSS/dataverse/blob/develop/conf/docker-aio/run-test-suite.sh#L11
# beware DataversesIT and DatasetsIT at minimum must be run for any other tests to succeed. have fun.
Expand Down
2 changes: 2 additions & 0 deletions tests/group_vars/memorytests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,11 @@ dataverse:
allow_signups: true
api:
allow_lookup: false
bearer_auth: false
blocked_endpoints: "admin,test"
blocked_policy: "localhost-only"
location: "http://localhost:8080/api"
session_auth: false
test_suite: false
# possible test values from https://github.com/IQSS/dataverse/blob/develop/conf/docker-aio/run-test-suite.sh#L11
# beware DataversesIT and DatasetsIT at minimum must be run for any other tests to succeed. have fun.
Expand Down
2 changes: 2 additions & 0 deletions tests/group_vars/vagrant.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,11 @@ dataverse:
allow_signups: true
api:
allow_lookup: false
bearer_auth: true
blocked_endpoints: "admin,test"
blocked_policy: "localhost-only"
location: "http://localhost:8080/api"
session_auth: true
test_suite: false
# possible test values from https://github.com/IQSS/dataverse/blob/develop/conf/docker-aio/run-test-suite.sh#L11
# beware DataversesIT and DatasetsIT at minimum must be run for any other tests to succeed. have fun.
Expand Down
⚡