Minor changes on Ontoportal select2 labels#49
Merged
Conversation
…hort Us897 remove input too short
qqmyers
approved these changes
Nov 4, 2025
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Looks OK to me, although I don't see the inputTooShort entry being used.
In general, if you're just changing code you manage, feel free to merge directly.
Collaborator
Author
|
@qqmyers thank for you the feedback :) Yes, we decided to remove the inputTooShort message to improve the user experience while using the connector (arguing that "x characters missing" message conflicted with "type a full word"). |
Collaborator
Author
|
@qqmyers I don't have the rights to merge. |
Member
|
FWIW: I didn't catch that inputTooShort is used by the select2 component (versus elsewhere in the ontoportal script itself). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.