Conversation
|
LGTM |
|
|
||
| To do this, install boot2docker [on Windows](https://github.com/boot2docker/windows-installer/releases) | ||
| or [on OS X](https://github.com/boot2docker/osx-installer/releases) and make | ||
| To do this, install boot2docker {on Windows}(https://github.com/boot2docker/windows-installer/releases) |
There was a problem hiding this comment.
iiuc, these should be curly then square brackets, e.g. {text}[url]
|
|
||
| If you want to install as a signed gem, the public certs of the gem signers | ||
| can be found in {the `certs` directory}[https://bitbucket.org/ged/ruby-pg/src/tip/certs/] | ||
| can be found in {the `certs` directory}[https://github.com/ged/ruby-pg/tree/master/certs] |
There was a problem hiding this comment.
It might be possible to use a relative link here, [certs] or [certs/].
There was a problem hiding this comment.
Relative links would only work when rendered on Github, right?
There was a problem hiding this comment.
Yes, true. The word "directory" made me think of a local checkout.
Since this is about installation, an absolute URL makes sense.
|
@ged I just got a notification from the mail system that my mail to ged at faeriemud dot org couldn't be delivered. So here is it again: Hi Michael, I fully agree with you regarding to moving to Github. I could also live Regarding issues migration I did a quick attempt with the following -- |
|
Sorry about the email bounce. We've been having mysterious hardware issues on our mailserver. And yeah, please do import the issues, @larskanis . That looks great! I'll fix the issues from your review when I get home tonight @cbandy. Thanks for the review. |
|
@ged Issue migration to GitHub ged/ruby-pg failes probably due to permissions with 404 like here: jeffwidman/bitbucket-issue-migration#88 |
|
You apparently can't grant admin permissions on personal accounts, but I'm happy to run the script myself. |
|
@ged Issue migration should work like so: $ git clone https://github.com/larskanis/bitbucket-issue-migration --branch nickname
$ cd bitbucket-issue-migration
$ python3 -m venv ./py3 # As described in the README
$ source ./py3/bin/activate
$ pip3 install -r requirements.pipNow run the first batch of issues: python3 migrate.py ged/ruby-pg ged/ruby-pg gedThis however stopped for me at issue 34 complaining about the missing tag "Documentation". So I renamed "documentation" to "Documentation" on the github page and restarted with: python3 migrate.py ged/ruby-pg ged/ruby-pg ged -f 34Then it did run through all remaining 265 issues. |
|
I just noticed, that we already are at #43 due to the pull requests, that are already on this repository and due to the fact that github uses a common counter for issues and pull requests. So we probably either can't migrate issues 1 to 43 from bitbucket or have to add an offset of 43 to all the issues. |
|
Ah, right okay. I think that since #43 is 8 years old at this point just omitting them should be fine. It might lead to weirdness with old links, but that's probably inevitable anyway. |
|
Okay, most of the issues are pulled over. I had a few false starts, so the earliest tickets have mismatched numbers, but everything after #47 or so should be correct. I'll shut down the Bitbucket project later tonight, then maybe push a release when you merge in the record encoder stuff? |
|
@ged imported issues look good - thanks Michael! So I think the bitbucket project can be shut down. One remaining issue is that the Appveyor project is still linked to bitbucket instead of GitHub. Can you please fix it and possibly update the badge link in the Readme? |
Since Bitbucket is shutting down support for Mercurial, and most of the work is done via git nowadays, there’s no reason to keep ruby-pg there any longer.