Handle PGRES_COMMAND_OK in pgresult_stream_any#447
Merged
larskanis merged 1 commit intoged:masterfrom Mar 23, 2022
Merged
Conversation
Fixes usage when trying to stream the result of a procedure call that returns no results.
Collaborator
|
Thanks for working on this! Although single_row_mode is not intended for this use case, the change makes sense for consistency. Not only the CALL command is affected but also INSERT, CREATE etc. So my test case is a bit simpler: ee4bf3d Do you need a release with this change? |
Contributor
Author
|
It seems like a corner case, so I don't think we need a release right away. We can wait for the normal release schedule. |
Collaborator
|
OK, thank you for working together once again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes usage when trying to stream the result of a procedure
call that returns no results.
Fixes Sequel tests when Sequel is set to stream all results.
Here's a reproducer that just uses ruby-pg without Sequel: