Skip to content

Fix typos#566

Merged
larskanis merged 1 commit intoged:masterfrom
myfloss:fix-typos
Apr 26, 2024
Merged

Fix typos#566
larskanis merged 1 commit intoged:masterfrom
myfloss:fix-typos

Conversation

@kianmeng
Copy link
Copy Markdown
Contributor

Found via codespell -L te,wronly,noes,nulll and typos --format brief


# Alias the +old+ type to the +new+ type.
def alias_type(format, new, old)
[:encoder, :decoder].each do |ende|
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ende means encoder-decoder in this context. It is no spelling mistake.

@larskanis
Copy link
Copy Markdown
Collaborator

Thank you very much for scanning and correction! It's all OK with the exception of ende->end.

Found via `codespell -L te,wronly,noes,nulll,ende` and `typos --format brief`
@kianmeng kianmeng requested a review from larskanis April 26, 2024 07:19
@larskanis larskanis merged commit 897042a into ged:master Apr 26, 2024
@larskanis
Copy link
Copy Markdown
Collaborator

Nice - thank you!

Comment thread ext/pg.c
*
* The SQLSTATE code for the error.
* The SQLSTATE code identies the type of error that has occurred; it can be used by front-end applications to perform specific operations (such as error handling) in response to a particular database error.
* The SQLSTATE code identities the type of error that has occurred; it can be used by front-end applications to perform specific operations (such as error handling) in response to a particular database error.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: identifies

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.


def initialize
# The key of these hashs maps to the `typname` column from the table pg_type.
# The key of these hashes maps to the `typname` column from the table pg_type.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: hash

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #567 to better describe the content of @coders_by_name. Is it OK?

larskanis added a commit to larskanis/ruby-pg that referenced this pull request Apr 26, 2024
@kianmeng
Copy link
Copy Markdown
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants