Exclude CI files from built gem#591
Merged
larskanis merged 2 commits intoged:masterfrom Sep 20, 2024
Merged
Conversation
Security inspection of some users or even their clients can be confused by finding out unknown YAML files with `Download` instructions inside final production releases. We can just get rid of them. Also Regex is fixed now, `/` before closing `)` was breaking.
cbandy
reviewed
Sep 18, 2024
They're supposed to be hidden, or non-important.
Contributor
Author
|
I see CI fails, the same as in the current (this PR doesn't touch any tests or CIs) |
Collaborator
|
Thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security inspection of some users or even their clients can be confused by finding out unknown YAML files with
Downloadinstructions inside final production releases. We can just get rid of them.Also Regex is fixed now,
/before closing)was breaking.