Skip to content

Core: short circuit protocol detection for S3#10012

Merged
bpandola merged 1 commit intogetmoto:masterfrom
bpandola:fix-10010
May 5, 2026
Merged

Core: short circuit protocol detection for S3#10012
bpandola merged 1 commit intogetmoto:masterfrom
bpandola:fix-10010

Conversation

@bpandola
Copy link
Copy Markdown
Collaborator

@bpandola bpandola commented May 5, 2026

We can't rely on the ContentType header because it's often set based on the MIME type of the object data being uploaded.

Closes #10010
Supersedes and Closes #10011

We can't rely on the ContentType header because it's often set based on the
MIME type of the object data being uploaded.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.20%. Comparing base (665e817) to head (a11da25).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10012   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files        1328     1328           
  Lines      120734   120736    +2     
=======================================
+ Hits       112535   112537    +2     
  Misses       8199     8199           
Flag Coverage Δ
servertests 28.92% <100.00%> (+<0.01%) ⬆️
unittests 93.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bpandola bpandola merged commit b4f8b78 into getmoto:master May 5, 2026
79 of 80 checks passed
@bpandola bpandola deleted the fix-10010 branch May 5, 2026 01:15
@martindurant
Copy link
Copy Markdown

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3: protocol detection fails when ContentType header set to MIME type of object data being uploaded

2 participants