Core: short circuit protocol detection for S3#10012
Merged
bpandola merged 1 commit intogetmoto:masterfrom May 5, 2026
Merged
Conversation
We can't rely on the ContentType header because it's often set based on the MIME type of the object data being uploaded.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10012 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 1328 1328
Lines 120734 120736 +2
=======================================
+ Hits 112535 112537 +2
Misses 8199 8199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't rely on the ContentType header because it's often set based on the MIME type of the object data being uploaded.
Closes #10010
Supersedes and Closes #10011