Skip to content

Route53: update_health_check() should handle falsy values correctly#10014

Merged
bblommers merged 1 commit intogetmoto:masterfrom
bblommers:route53-update-health-check-booleans
May 5, 2026
Merged

Route53: update_health_check() should handle falsy values correctly#10014
bblommers merged 1 commit intogetmoto:masterfrom
bblommers:route53-update-health-check-booleans

Conversation

@bblommers
Copy link
Copy Markdown
Collaborator

Fixes #10013

Values should always be updated if they are not None. The user only mentioned the boolean values not being set, but this applies to all falsy values - [], 0 are also valid values.

@bblommers bblommers added this to the 5.2.1 milestone May 5, 2026
@bblommers bblommers requested a review from bpandola May 5, 2026 20:00
Copy link
Copy Markdown
Collaborator

@bpandola bpandola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @bblommers! These boolean strings have been a real pain during the request parsing/response serialization refactor, but I still think it's important that we convert them. Unfortunately, the three in question here had no test coverage and I failed to spot them. I appreciate you jumping on this so quickly!

@bblommers bblommers merged commit 6b3cf8d into getmoto:master May 5, 2026
65 of 66 checks passed
@bblommers bblommers deleted the route53-update-health-check-booleans branch May 5, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Impossible to re-enable health checks in version 5.2

2 participants