Techdebt: Remove warnings#7350
Merged
bblommers merged 1 commit intogetmoto:masterfrom Feb 17, 2024
Merged
Conversation
e8811d8 to
137de15
Compare
137de15 to
d88001c
Compare
d88001c to
abf59a2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7350 +/- ##
==========================================
- Coverage 95.88% 95.86% -0.03%
==========================================
Files 843 843
Lines 82578 82838 +260
==========================================
+ Hits 79178 79410 +232
- Misses 3400 3428 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
This is now part of moto >= 5.0.2.dev26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cryptography >= 40.0.0 introduces a new property,
not_valid_before_utc, that will replace the oldnot_valid_before-property. This PR supports both properties (and therefore all versions of cryptography).This PR also:
cryptographypytestwarnings since tests (methods that start withtest_) should not return anything