Cognito: update UserLastModifiedDate when changing user attributes#7464
Merged
bblommers merged 1 commit intogetmoto:masterfrom Mar 14, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7464 +/- ##
==========================================
- Coverage 95.88% 95.80% -0.08%
==========================================
Files 843 854 +11
Lines 82578 83990 +1412
==========================================
+ Hits 79178 80470 +1292
- Misses 3400 3520 +120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Mar 14, 2024
Collaborator
bblommers
left a comment
bblommers
left a comment
There was a problem hiding this comment.
LGTM - thanks for the fix @schmittjoaopedro!
Contributor
|
This is now part of moto >= 5.0.4.dev12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is not updating the Cognito IDP User field UserLastModifiedDate when updating or removing attributes. So this change proposes to fix this.