[Bug Fix] Directory Service - change settings init to deep copy#8434
Merged
bblommers merged 2 commits intogetmoto:masterfrom Dec 25, 2024
Merged
[Bug Fix] Directory Service - change settings init to deep copy#8434bblommers merged 2 commits intogetmoto:masterfrom
bblommers merged 2 commits intogetmoto:masterfrom
Conversation
Collaborator
|
Can you merge in the latest master @zkarpinski? That should fix the build - happy to merge afterwards |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8434 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 1168 1168
Lines 101701 101702 +1
=======================================
+ Hits 96214 96215 +1
Misses 5487 5487
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings list of dictionaries is a shadow copy, resulting in unexpected results when there are 2+ directories with changed settings.
A deep copy resolves this issue.