Skip to content

S3: delete_objects(): BypassGovernanceMode should handle both True and true#8752

Merged
bpandola merged 1 commit intogetmoto:masterfrom
bblommers:s3/delete-objects-governance-retention-casing
Apr 1, 2025
Merged

S3: delete_objects(): BypassGovernanceMode should handle both True and true#8752
bpandola merged 1 commit intogetmoto:masterfrom
bblommers:s3/delete-objects-governance-retention-casing

Conversation

@bblommers
Copy link
Copy Markdown
Collaborator

Looks like the casing changed (True -> true in a recent botocore update (potentially this one), and Moto didn't understand the provided parameter anymore. This should fix the tests on master.

@bblommers bblommers added this to the 5.1.3 milestone Apr 1, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (448c745) to head (9230a00).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8752   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files        1260     1260           
  Lines      109606   109606           
=======================================
  Hits       101723   101723           
  Misses       7883     7883           
Flag Coverage Δ
servertests 28.21% <ø> (ø)
unittests 92.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bpandola
Copy link
Copy Markdown
Collaborator

bpandola commented Apr 1, 2025

Just out of curiosity, I went digging for the change. It's here.

@bpandola bpandola merged commit b851c8f into getmoto:master Apr 1, 2025
56 checks passed
@bblommers
Copy link
Copy Markdown
Collaborator Author

Just out of curiosity, I went digging for the change. It's here.

They changed the entire serialization format so that all querystring booleans are now lowercased.. and our implementation only failed once? I'm impressed 🙂

@bblommers bblommers deleted the s3/delete-objects-governance-retention-casing branch April 2, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants