[SQS] [Fix] Implements full support for 1MB SQS message size#9682
Merged
bpandola merged 2 commits intogetmoto:masterfrom Jan 30, 2026
Merged
[SQS] [Fix] Implements full support for 1MB SQS message size#9682bpandola merged 2 commits intogetmoto:masterfrom
bpandola merged 2 commits intogetmoto:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9682 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 1302 1302
Lines 118298 118295 -3
=======================================
- Hits 110114 110113 -1
+ Misses 8184 8182 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bpandola
approved these changes
Jan 30, 2026
Collaborator
bpandola
left a comment
There was a problem hiding this comment.
Thanks @henryivesjones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the current SQS
send_messageimplementation that doesn't allow messages > 256KB to be sent. That limitation has been raised to 1MiB in AWS. This fix correctly sets a given queues max message size to the value set when creating the queue.At present there are two separate places that the maximum size for an sqs message is defined. One of them contains the old value of 256KB. This value is used in a pre-check within the
send_messagemethod.My change consolidate that size max to a single definition and removes this pre-check. There is another check on the
sqs_backendthat enforces the actual size limit for the given queue. The queue model has protections on the attribute being set as well as a default value so I believe that this extra check is unnecessary.I added a test case that would have caught this bug as well as fixed a test that referenced the
256KBlimit.