Migrate EMR services to new request parsing/response serialization#9973
Merged
bpandola merged 3 commits intogetmoto:masterfrom Apr 12, 2026
Merged
Migrate EMR services to new request parsing/response serialization#9973bpandola merged 3 commits intogetmoto:masterfrom
bpandola merged 3 commits intogetmoto:masterfrom
Conversation
Botocore's data directory allows hyphens, but Moto's core directory consists of Python modules (which cannot contain hyphens) alongside data files. Here we wrap the Botocore method for finding extras and inject the Moto directory name before calling the super class. This allows for loading the main service specification from Botocore and the extras from Moto when the directory names differ (e.g. `emr-containers` -> `emrcontainers`).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9973 +/- ##
==========================================
- Coverage 93.19% 93.18% -0.01%
==========================================
Files 1321 1321
Lines 120294 120217 -77
==========================================
- Hits 112102 112022 -80
- Misses 8192 8195 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the EMR Containers and EMR Serverless backends to the new request parsing/response serialization:
ActionResulthelpersFakeCluster→VirtualCluster,FakeJob→JobRun(align with AWS naming)__iter__andto_dict()methods; model now returns objects directlypaginated_listfunction, now handled by corePaginatedResulthelperdatetimeobjectsAlso adds a fix for the core data loader to ensure that Moto "extras" can still be found when Moto's data directory differs from Botocore's (e.g.
emr-containers→emrcontainers).Closes #9922
Supersedes and Closes #9923