?timeout=N is being ignored in the DSN

[mgedmin]

Try this:

nc -k -l -p 9000  # have netcat listen on port 9000

then on a different terminal

python
>>> import raven
>>> raven.Client('http://user:password@localhost:9000/1?timeout=30').send()

Observe how the send() method times out after 1 second instead of the desired 30.

[mgedmin]

This is sufficient to make the timeout work, but as a side effect it passes ?timeout=N in the POST requests to the Sentry server, which might be undesirable:

diff --git a/raven/transport/base.py b/raven/transport/base.py
index 3bf4f2d..8b083c7 100644
--- a/raven/transport/base.py
+++ b/raven/transport/base.py
@@ -154,6 +154,8 @@ class HTTPTransport(Transport):

     def __init__(self, parsed_url, timeout=defaults.TIMEOUT):
         self.check_scheme(parsed_url)
+        if isinstance(timeout, basestring):
+            timeout = float(timeout)

         self._parsed_url = parsed_url
         self._url = parsed_url.geturl()
@@ -188,6 +190,8 @@ class HTTPTransport(Transport):
             raise ValueError('Invalid Sentry DSN: %r' % url.geturl())

         server = '%s://%s%s/api/store/' % (url.scheme, netloc, path)
+        if url.query:
+            server += '?%s' % url.query
         scope.update({
             'SENTRY_SERVERS': [server],
             'SENTRY_PROJECT': project,

[temoto]

👍 it is more convenient to set timeout via DSN.

[xordoquy]

Indeed, setting this via DSN is the way to go.

[xordoquy]

Fixed in commit 6c14350