This repository was archived by the owner on Oct 23, 2023. It is now read-only.
fix: Fix stacktraces in some situations being the wong way round#1261
Merged
fix: Fix stacktraces in some situations being the wong way round#1261
Conversation
Contributor
Author
|
@mattrobenolt as far as I can tell this was wrong forever but since the tests were also incorrect and it's late here I want a second pair of eyes that have seen this code before. |
Contributor
|
Yeah, this code here is only used when generating a synthetic stacktrace, right? When we have a real traceback, we do the right thing. |
mattrobenolt
approved these changes
Jun 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oddly enough even the tests were wrong.