refactor(snapshot): Remove MergeClassesTask, scan classpath in-place

[romtsn]

Summary

• Eliminates MergeClassesTask by scanning classes directly from their source locations (directories and JARs) instead of merging them into an intermediate directory first
• Moves classpath resolution into ExportPreviewMetadataTask.register() and adds a forEachClassEntry() helper that iterates both loose .class files and JAR entries in-place
• No intermediate merged-classes directory is written to disk anymore

Test plan

• Existing ExportPreviewMetadataTaskTest tests pass
• spotlessCheck passes
• compileKotlin succeeds

🤖 Generated with Claude Code

[github-actions]

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

---

Internal Changes 🔧

• (snapshot) Remove MergeClassesTask, scan classpath in-place by romtsn in #1121

• Pin GitHub Actions to full-length commit SHAs by joshuarli in #1116

---

_{🤖 This preview updates automatically when you update the PR.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Unused android parameter in register method
  • Removed the unused BaseExtension parameter and import, and updated the caller accordingly.

Or push these changes by commenting:

@cursor push d17fed0e0a

Preview (d17fed0e0a)

diff --git a/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/ExportPreviewMetadataTask.kt b/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/ExportPreviewMetadataTask.kt
--- a/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/ExportPreviewMetadataTask.kt
+++ b/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/ExportPreviewMetadataTask.kt
@@ -1,6 +1,5 @@
 package io.sentry.android.gradle.snapshot.metadata
 
-import com.android.build.gradle.BaseExtension
 import groovy.json.JsonOutput
 import java.util.zip.ZipInputStream
 import org.gradle.api.DefaultTask
@@ -155,7 +154,6 @@
     fun register(
       project: Project,
       extension: SentrySnapshotMetadataExtension,
-      android: BaseExtension,
     ): TaskProvider<ExportPreviewMetadataTask> {
       return project.tasks.register(
         "exportPreviewMetadata",

diff --git a/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/SentrySnapshotMetadataPlugin.kt b/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/SentrySnapshotMetadataPlugin.kt
--- a/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/SentrySnapshotMetadataPlugin.kt
+++ b/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/SentrySnapshotMetadataPlugin.kt
@@ -1,6 +1,5 @@
 package io.sentry.android.gradle.snapshot.metadata
 
-import com.android.build.gradle.BaseExtension
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 
@@ -15,8 +14,7 @@
       )
 
     fun wireWithAndroid() {
-      val android = project.extensions.getByType(BaseExtension::class.java)
-      ExportPreviewMetadataTask.register(project, extension, android)
+      ExportPreviewMetadataTask.register(project, extension)
     }
 
     project.pluginManager.withPlugin("com.android.library") { wireWithAndroid() }

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

[cursor]

Unused android parameter in register method

Low Severity

The android: BaseExtension parameter in register() is never referenced in the method body. The classpath resolution uses project.configurations and project.tasks directly, making the parameter dead code. Its corresponding import com.android.build.gradle.BaseExtension is also unused by the task class itself. The caller in SentrySnapshotMetadataPlugin still fetches and passes it needlessly.

Additional Locations (1)

• plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/metadata/ExportPreviewMetadataTask.kt#L2-L3

 

[runningcode]

this works! thank you for the performance improvement!